fix: #20878 Provide " as member" where needed#20887
Closed
robertleeplummerjr wants to merge 1 commit intoOpenAPITools:masterfrom
Closed
fix: #20878 Provide " as member" where needed#20887robertleeplummerjr wants to merge 1 commit intoOpenAPITools:masterfrom
robertleeplummerjr wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
- Generate new samples - Add tests for all effected python versions - Ran tests with success Commands used to verify: ./bin/generate-samples.sh ./bin/configs/python* mvn verify -Psamples mvn integration-test -f modules/openapi-generator/pom.xml -Dtest=org.openapitools.codegen.python.PythonPydanticV1ClientCodegenTest -e mvn integration-test -f modules/openapi-generator/pom.xml -Dtest=org.openapitools.codegen.python.PythonClientCodegenTest -e
Author
|
Mentioning Members of Technical Committee: @cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10) |
|
|
||
| @Test(description = "outputs __init__.py with imports for exports") | ||
| public void testInitFileImportsExports() throws IOException { | ||
| File output = Files.createTempDirectory("test").toFile().getCanonicalFile(); |
Author
There was a problem hiding this comment.
This probably could be simpler. I used an LLM to get a template to work from. I welcome any feedback.
Member
|
@robertleeplummerjr thanks for the pr. can you please review the build failure when you've time? |
Contributor
|
@wing328 I believe those errors to be unrelated to the changes introduced by this PR, possibly from the tests being fragile. I didn't see a place where I can re-run them but perhaps that would provide them a chance to run successfully. |
5 tasks
Member
|
fixed tests via #21304 closing this one. thanks again for the PR |
Author
|
You guys rock. This project is pretty fantastic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commands used to verify:
./bin/generate-samples.sh ./bin/configs/python* mvn verify -Psamples mvn integration-test -f modules/openapi-generator/pom.xml -Dtest=org.openapitools.codegen.python.PythonPydanticV1ClientCodegenTest -e mvn integration-test -f modules/openapi-generator/pom.xml -Dtest=org.openapitools.codegen.python.PythonClientCodegenTest -eI didn't include the updates to all samples, only those for python, but I do have a commit for all samples here: e014bb2
I omitted because I didn't want to cause a conflict.
to close #20878
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)